Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LUT and species clipping #1761

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

Give a brief overview of your contribution here in a few sentences.

  1. arrays in gettriangle need to be size 2 instead of 3
  2. error message that checks species clipping only checks if the keyword is present, not if clipping is on
  3. added setblock_zero "per-species" to CSysVector (added here to reduce the mega-PR for the flamelet model)
  4. fix speling eror

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted bigfooted changed the title Fix lut and species clipping Fix LUT and species clipping Sep 14, 2022
@bigfooted bigfooted added the bug label Sep 14, 2022
* \param[in] iPoint - Index of the block being set to zero.
* \param[in] iVar - Index of the variable being set to zero.
*/
inline void SetBlock_Zero(unsigned long iPoint, unsigned long iVar) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed, just do vector(ipoint, ivar) = 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I get it, we directly do LinSysRes(iPoint,iVar) = 0 and we do not introduce this function at all.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep 👍

@bigfooted bigfooted merged commit 88c8392 into develop Sep 14, 2022
@bigfooted bigfooted deleted the fix_LUT_and_species_clipping branch September 14, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants