Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output heatfluxes (total and maximum) per surface #1534

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Output heatfluxes (total and maximum) per surface #1534

merged 5 commits into from
Feb 4, 2022

Conversation

pcarruscag
Copy link
Member

Closes #1531

@pcarruscag pcarruscag mentioned this pull request Feb 3, 2022
Closed
@pcarruscag pcarruscag linked an issue Feb 3, 2022 that may be closed by this pull request
Enable per-surface heatflux monitoring in history #1531
Closed
TobiKattmann
TobiKattmann approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcarruscag for tackling that issue, I saw it as well but pretended to haven't seen it :D

LGTM

My comments are minor things. The only real thing is that I think AVG_TEMPERATURE should be removed for the flow_solver

SU2_CFD/src/output/CFlowIncOutput.cpp
AddAerodynamicCoefficients(config);

if (heat || weakly_coupled_heat) {
AddHeatCoefficients(config);
AddHistoryOutput("AVG_TEMPERATURE", "Temp", ScreenOutputFormat::SCIENTIFIC, "HEAT", "Average temperature on all surfaces set with MARKER_MONITORING.", HistoryFieldType::COEFFICIENT);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a side note: For an AvgTemp OF for the flow solver one needs to use SURFACE_STATIC_TEMPERATURE (which works with MARKER_ANALYZE) and not AVG_TEMPERATURE. For solid domains it is AVG_TEMPERATURE though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about weakly_coupled_heat?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you're right. There one would use AVG_TEMPERATURE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I won't stick my hand in that xD

@pcarruscag pcarruscag merged commit a503f74 into develop Feb 4, 2022
@pcarruscag pcarruscag deleted the output_hf_per_surf branch February 4, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiKattmann TobiKattmann TobiKattmann approved these changes

Assignees
No one assigned
Labels
changelog:feature PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable per-surface heatflux monitoring in history
2 participants
@pcarruscag @TobiKattmann