Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for new libROM API #1436

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Changes for new libROM API #1436

merged 2 commits into from
Nov 16, 2021

Conversation

jtlau
Copy link
Contributor

@jtlau jtlau commented Nov 11, 2021

Proposed Changes

Small updates due to changes in libROM API (corresponds to PR LLNL/libROM#80 )

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • [ x] I am submitting my contribution to the develop branch.
  • [ x] My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
  • [ x] My contribution is commented and consistent with SU2 style.
  • [ n/a] I have added a test case that demonstrates my contribution, if necessary.
  • [ x] I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to list the new version somewhere?

@pcarruscag pcarruscag changed the title changes for new librom api Changes for new libROM API Nov 12, 2021
Copy link
Contributor

@TobiKattmann TobiKattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have it as a submodule? Then the compatibility between SU2 and librom does not depend someone's knowledge which librom version has to be used.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jtlau
Copy link
Contributor Author

jtlau commented Nov 16, 2021

I'm going to pull this in for now, but I'll look into adding libROM as a subproject. libROM has a handful of prerequisites (hdf5, mpi, lapack, etc) so leaving it as a standalone project might be easier

@jtlau jtlau merged commit 0a053ef into develop Nov 16, 2021
@jtlau jtlau deleted the update_librom branch November 16, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants