CFVMOutput & Streamwise+spanwise periodic #1290

TobiKattmann · 2021-05-19T11:59:17Z

Proposed Changes

Hi all,

Little change to make streamwise and spanwise periodic simulations possible (in CIncNSSolver.cpp).
Some cleanup in CConjugateHeatInterface
Added a CFVMOutput class that only has a CommonFVMoutput for Volume output (COORD-XYZ (fresh addition), MESH_QUALITY, Multigrid visualization and RANK)
in the output folder(s) there were quite some wrong doxygen \file <filename>, i changed that. I renamed CAdjFlowOutput.hpp -> CAdjFlowCompOutput.hpp as the cpp as that name and that class as well.
little changes/additions to unst CHT gradient validation case

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.

…wise_spanwise_periodic

…e_periodic

…vidual FVM outputs.

TobiKattmann · 2021-06-05T16:33:29Z

TestCases/coupled_cht/disc_adj_unsteadyCHT_cylinder/gradient_validation.py

@@ -80,7 +80,7 @@
 adjoint.addExpected("solution_adj_avtp_1_00053.dat")

 # gradient projection
-dot = adjont = ExternalRun("DOT",dot_ad_command,True)
+dot = ExternalRun("DOT",dot_ad_command,True)


Thanks to @danielmayer for these changes

TobiKattmann · 2021-06-05T16:42:16Z

The CodeFactor issue is the usual Complex Code in CSolver.hpp so it can be discarded. Otherwise I have not really more to add

pcarruscag

thanks 👍 few comments below

SU2_CFD/src/drivers/CMultizoneDriver.cpp

SU2_CFD/src/output/CFVMOutput.cpp

SU2_CFD/src/solvers/CIncNSSolver.cpp

SU2_CFD/include/output/CFVMOutput.hpp

SU2_CFD/src/meson.build

…rom individual FVM outputs." This reverts commit 43e3690.

SU2_CFD/src/drivers/CMultizoneDriver.cpp

SU2_CFD/src/output/CFVMOutput.cpp

SU2_CFD/include/output/CFVMOutput.hpp

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

TobiKattmann · 2021-06-08T16:52:46Z

Thanks for the review and fixing the mistakes @pcarruscag

pcarruscag · 2021-06-08T17:01:18Z

No no, thank you for continuing to improve the code.

Debugging streamwise x spanwise periodicty.

b5d0ed1

pr-triage bot added the PR: unreviewed label May 19, 2021

TobiKattmann changed the title ~~Streamwise + spanwise periodic~~ [WIP] Streamwise + spanwise periodic May 19, 2021

pr-triage bot removed the PR: unreviewed label May 19, 2021

TobiKattmann marked this pull request as draft May 19, 2021 12:00

pr-triage bot added the PR: draft label May 19, 2021

TobiKattmann added 17 commits May 20, 2021 11:18

Merge remote-tracking branch 'origin/hybrid_parallel_ad3' into stream…

10bc05f

…wise_spanwise_periodic

small cleanup CHeatSolver

c08535e

remove fenv debugging stuff

41d1f9c

lil'cleanup CConjugateHeatInterface

ee34008

remove debug output

97455a1

Maybe uninitialized fix

465a75a

I should build locally before I push...

953508f

fml

8968a1b

Merge remote-tracking branch 'origin/hybrid_parallel_ad3' into stream…

b16aa2e

…wise_spanwise_periodic

Merge remote-tracking branch 'origin/hybrid_parallel_ad3' into stream…

3ae1f55

…wise_spanwise_periodic

Merge remote-tracking branch 'origin/hybrid_parallel_ad3' into stream…

9fe6f88

…wise_spanwise_periodic

Merge branch 'hybrid_parallel_ad3' into streamwise_spanwise_periodic

07b9ff2

Merge remote-tracking branch 'origin/develop' into streamwise_spanwis…

4d4b67d

…e_periodic

Replace auto-type with su2double for introduced changes

02442b6

Change Multizone TimeRef. Tiny changes in CHTinterface.

0e1e58f

Add CFVMOutput and move CommonOutput there.

cae07a6

Add Coord-XYZ to fresh CFVMOutput and therefore remove that from indi…

43e3690

…vidual FVM outputs.

TobiKattmann changed the title ~~[WIP] Streamwise + spanwise periodic~~ CFVMOutput & Streamwise+spanwise periodic Jun 2, 2021

TobiKattmann marked this pull request as ready for review June 2, 2021 16:10

pr-triage bot added PR: unreviewed and removed PR: draft labels Jun 2, 2021

Fix doxygen filenames for output folder.

bd952cf

TobiKattmann added changelog:chore changelog:feature labels Jun 2, 2021

TobiKattmann added 2 commits June 5, 2021 18:28

Revert some autos into su2double, for safety you know

4ce75fa

Little changes to unst CHT grad validation files

07a1b34

TobiKattmann commented Jun 5, 2021

View reviewed changes

pcarruscag reviewed Jun 5, 2021

View reviewed changes

TobiKattmann added 4 commits June 5, 2021 20:05

Adress PR review comments: readding autos and stuff in CFVMOutput.

41109fe

Revert "Add Coord-XYZ to fresh CFVMOutput and therefore remove that f…

9b6ae98

…rom individual FVM outputs." This reverts commit 43e3690.

AddCoordinates routine for CFVMOutput

1ebee47

TimeRef multizoneDriver

034eb5a

pcarruscag reviewed Jun 6, 2021

View reviewed changes

TobiKattmann and others added 5 commits June 6, 2021 17:17

Multizone TimeRef update 1/2

cd175e6

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Multizone TimeRef update 2/2

f52092d

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Templated input Coord to CFVMOutput::LoadCoordinates 1/2

e5f6d4f

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Templated input Coord to CFVMOutput::LoadCoordinates 2/2

80f8a3e

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Move unsteady CHT regression test to tutorials.py.

1771391

pcarruscag approved these changes Jun 8, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jun 8, 2021

TobiKattmann merged commit 919900a into develop Jun 8, 2021

TobiKattmann deleted the streamwise_spanwise_periodic branch June 8, 2021 16:52

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jun 8, 2021

TobiKattmann mentioned this pull request Jun 11, 2021

Fix restart logic in python FSI #1295

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CFVMOutput & Streamwise+spanwise periodic #1290

CFVMOutput & Streamwise+spanwise periodic #1290

TobiKattmann commented May 19, 2021 •

edited

Loading

TobiKattmann Jun 5, 2021

TobiKattmann commented Jun 5, 2021

pcarruscag left a comment

TobiKattmann commented Jun 8, 2021

pcarruscag commented Jun 8, 2021

CFVMOutput & Streamwise+spanwise periodic #1290

CFVMOutput & Streamwise+spanwise periodic #1290

Conversation

TobiKattmann commented May 19, 2021 • edited Loading

Proposed Changes

PR Checklist

TobiKattmann Jun 5, 2021

Choose a reason for hiding this comment

TobiKattmann commented Jun 5, 2021

pcarruscag left a comment

Choose a reason for hiding this comment

TobiKattmann commented Jun 8, 2021

pcarruscag commented Jun 8, 2021

TobiKattmann commented May 19, 2021 •

edited

Loading