Add DFP endpoints #348
Merged
Add DFP endpoints #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
logan-stytch
approved these changes
Jan 3, 2025
jennifer-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
jennifer-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
jennifer-stytch
temporarily deployed
to
integration_tests
GitHub Actions
Inactive
max-stytch
approved these changes
Jan 6, 2025
lib/shared/index.ts
Outdated
| }; | ||
|
|
||
| export async function request<T>( | ||
| fetchConfig: fetchConfig, | ||
| requestConfig: requestConfig | ||
| ): Promise<T> { | ||
| const url = new URL(requestConfig.url, fetchConfig.baseURL); | ||
| const baseURL = | ||
| requestConfig.baseURLType && requestConfig.baseURLType == "FRAUD" |
There was a problem hiding this comment.
- In JS, pretty much always prefer
===over==. - No need to check for truthiness here -
undefined == "FRAUD"will produce false
Suggested change
| requestConfig.baseURLType && requestConfig.baseURLType == "FRAUD" | |
| requestConfig.baseURLType === "FRAUD" |
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
jennifer-stytch
had a problem deploying
to
integration_tests
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the two backend DFP endpoints:
/v1/fingerprint/lookupand/v1/rules/setMarking as MAJOR because of the
metric_typefix from optional to required.