[WEB-2139] demo top nav #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
plin-stytch
requested review from
a team,
pverheecke-stytch and
clee-stytch
and removed request for
a team
| </Link> | ||
| <div style={styles.leftNav}> | ||
| <div style={styles.logoContainer}> | ||
| <Link href={'/'}> |
There was a problem hiding this comment.
Nit: I would do cursor: pointer for this
| </Link> | ||
| </div> | ||
| {windowInnerWidth > 1000 && ( | ||
| <div style={styles.leftLinks}> |
There was a problem hiding this comment.
These links feel closer together, larger, and bolder than the mocks
| padding: '8px 22px', | ||
| borderRadius: '3px', | ||
| }, | ||
| secondaryButton: { |
There was a problem hiding this comment.
It looks like in mocks this should be a ghost button
There was a problem hiding this comment.
Was a text button. Not sure why I didn't style this one after I did the other two 😂
|
Updated! Screen.Recording.2024-06-13.at.1.27.52.PM.mov |
allison-stytch
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed demo top nav to look like the Figma: https://www.figma.com/design/qBLLLwbJYGeZoca4m3lQD4/Onboarding-|-Q2-2024-|-HM?node-id=599-11503&m=dev
As the screen gets smaller, I progressively remove certain links. Dark mode does not change the background or text color (this is the pattern we are following for our marketing site).