Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Ticket: SDK-1400
Changes:
@JvmStatic
annotation to object properties (to prevent having to typeStytchClient.INSTANCE.[property]
)@JvmOverloads
constructors to data classes, where applicableUInt
to simpleInt
(because Java doesn't haveUInt
, andUInt
prevents usage of@JvmOverloads
; also, we were casting it toInt
before making the request anyway, so this reduces unnecessary overhead)configure
methods (ran into some oddities with@JvmOverloads
on these methods)val
instead ofvars
with internalset
, because it was causing the non-accessible setters to be visible; These were only set asvar
for unit tests, and I removed those few tests that relied on that.Notes:
Checklist: