Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop wasting time on versioned docs #184

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jhaven-stytch
Copy link
Contributor

Changes:

  1. Stop trying to generate versioned docs since we only expose latest version docs

Notes:

  • Since the introduction of the UI SDK, we've stopped supporting versioned docs, as Dokka multi module + versioning doesn't seem to be supported. We decided to just live with latest-version docs, but never updated the workflow. This was fine, but costly, as we were running doc generation for versions that were never going to be exposed. However, v0.25.0 introduced some changes that broke dokka generation (and have since been fixed), but that meant that attempting to generate versioned docs failed for that version and, thus, failed to generate any docs. So, this codifies that we are only doing latest version docs, gets our doc publishing working again, and maybe saves a little money on runners.

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner July 15, 2024 20:29
@jhaven-stytch jhaven-stytch merged commit a0e208d into main Jul 16, 2024
6 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/stop-doing-versioned-docs branch July 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants