Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK-1588 Enable CNAME domains for OAuth and SSO #146

Merged
merged 2 commits into from
Apr 16, 2024
Merged

SDK-1588 Enable CNAME domains for OAuth and SSO #146

merged 2 commits into from
Apr 16, 2024

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: SDK-1588

Changes:

  1. Use cname if available for oauth and sso

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner April 16, 2024 13:12
alex-stytch
alex-stytch approved these changes Apr 16, 2024
View reviewed changes
Copy link

@alex-stytch alex-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Seems like the last few PRs have had linting updates – is there a way we can lint all files to make reviewing a bit easier after?

@jhaven-stytch jhaven-stytch merged commit 35292d0 into main Apr 16, 2024
4 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-1588-cname-oauth branch April 16, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stytch alex-stytch alex-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @alex-stytch