Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1576 Fix potentially persisting/retrieving empty strings #144

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: SDK-1576

Changes:

  1. Add guardrail for a potentially empty string being returned for a session token in auth interceptor
  2. Ensure that we never persist or return an empty string from the storage helper
  3. Lint
  4. Version bump

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

…sion token; Ensure that we never persist or return an empty string from the storage helper;autolint
@jhaven-stytch jhaven-stytch requested a review from a team as a code owner April 10, 2024 16:47
@jhaven-stytch
Copy link
Contributor Author

UI tests are failing randomly because of AVD flakiness when transitioning between tests. Going to ignore it for this PR.

@jhaven-stytch jhaven-stytch merged commit b10e1d0 into main Apr 10, 2024
3 of 4 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-1576-empty-string-session-token branch April 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants