Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error simplification and additional tests #111

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Error simplification and additional tests #111

merged 1 commit into from
Dec 14, 2023

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: None

Changes:

  1. Dumb down StytchError to the basics
  2. Anything that is specific to a type of error (exception, url, etc) is only included for that type
  3. Update util functions in workbench apps to account for above changes
  4. Add some tests for each error type to make sure we're passing the correct name, etc

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch
Dumb down StytchError to only a name and description; All implementin…
1d3fd4f 
…g error types have their own properties as necessary; Add tests for each error class
@jhaven-stytch jhaven-stytch requested a review from a team as a code owner December 13, 2023 16:45
@jhaven-stytch jhaven-stytch requested review from susie-stytch and removed request for a team December 13, 2023 16:45
@jhaven-stytch jhaven-stytch merged commit 1c03eaa into feature/Error-Unification Dec 14, 2023
@jhaven-stytch jhaven-stytch deleted the jordan/error-url-only-where-valid branch December 14, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susie-stytch susie-stytch susie-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @susie-stytch