Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1316 Test new errors #109

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: SDK-1316

Changes:

  1. Make DeeplinkHandledStatus report only a subset of SDKErrors for better DX
  2. Minor refactoring for easier testing
  3. Add some missing tests
  4. Remove out some unused biometric-specific errors. On Android and iOS we expose the same information in an availability object (or a simple boolean). RN will be updated to match

Notes:

  • Not really a lot in this PR, but that's a good thing, because the other errors are already being tested for in existing tests

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner December 8, 2023 17:19
@jhaven-stytch jhaven-stytch requested review from susie-stytch and removed request for a team December 8, 2023 17:19
Copy link
Contributor

@susie-stytch susie-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhaven-stytch jhaven-stytch merged commit 0dfa510 into feature/Error-Unification Dec 8, 2023
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-1316-testing branch December 8, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants