Merge pull request #220 from stytchauth/jordan/SDK-2121-sms-oauth-val…

…id-primary SDK-2121 Remove primary authentication factor check
stytchauth · Oct 16, 2024 · 4aa3cdf · 4aa3cdf
2 parents 8652609 + 2d6cda3
commit 4aa3cdf
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 29 deletions.
diff --git a/source/sdk/build.gradle b/source/sdk/build.gradle
@@ -10,7 +10,7 @@ plugins {
 
 ext {
   PUBLISH_GROUP_ID = 'com.stytch.sdk'
-  PUBLISH_VERSION = '0.29.1'
+  PUBLISH_VERSION = '0.29.2'
   PUBLISH_ARTIFACT_ID = 'sdk'
 }
 

diff --git a/source/sdk/src/androidTest/java/com/stytch/sdk/ui/robots/StytchAuthenticationAppRobot.kt b/source/sdk/src/androidTest/java/com/stytch/sdk/ui/robots/StytchAuthenticationAppRobot.kt
@@ -13,8 +13,4 @@ internal class StytchAuthenticationAppRobot(
     fun isEMLAndOTPError(error: StytchUIInvalidConfiguration) {
         assert(error.message == getString(R.string.eml_and_otp_error))
     }
-
-    fun isMisconfiguredError(error: StytchUIInvalidConfiguration) {
-        assert(error.message == getString(R.string.misconfigured_products_and_options))
-    }
 }
diff --git a/source/sdk/src/androidTest/java/com/stytch/sdk/ui/tests/StytchAuthenticationAppTest.kt b/source/sdk/src/androidTest/java/com/stytch/sdk/ui/tests/StytchAuthenticationAppTest.kt
@@ -3,7 +3,6 @@ package com.stytch.sdk.ui.tests
 import com.stytch.sdk.common.errors.StytchUIInvalidConfiguration
 import com.stytch.sdk.ui.BaseAndroidComposeTest
 import com.stytch.sdk.ui.data.EML_AND_OTP_ERROR_STYTCH_UI_CONFIG
-import com.stytch.sdk.ui.data.NO_PASSWORD_EML_OR_OTP_STYTCH_UI_CONFIG
 import com.stytch.sdk.ui.robots.stytchAuthenticationAppRobot
 import org.junit.Test
 
@@ -21,16 +20,4 @@ internal class StytchAuthenticationAppTest : BaseAndroidComposeTest() {
             isEMLAndOTPError(error!!)
         }
     }
-
-    @Test
-    fun misconfiguredProductsAndOptionsReturnsError() {
-        stytchAuthenticationAppRobot {
-            var error: StytchUIInvalidConfiguration? = null
-            clearAndSetContent(NO_PASSWORD_EML_OR_OTP_STYTCH_UI_CONFIG) {
-                error = it
-            }
-            await()
-            isMisconfiguredError(error!!)
-        }
-    }
 }
diff --git a/source/sdk/src/main/java/com/stytch/sdk/ui/StytchAuthenticationApp.kt b/source/sdk/src/main/java/com/stytch/sdk/ui/StytchAuthenticationApp.kt
@@ -44,16 +44,6 @@ internal fun StytchAuthenticationApp(
         onInvalidConfig(StytchUIInvalidConfiguration(stringResource(id = R.string.eml_and_otp_error)))
         return
     }
-    if (
-        !productConfig.products.contains(StytchProduct.PASSWORDS) &&
-        // no passwords
-        !productConfig.products.contains(StytchProduct.EMAIL_MAGIC_LINKS) &&
-        // no EML
-        !productConfig.otpOptions.methods.contains(OTPMethods.EMAIL) // no Email OTP
-    ) {
-        onInvalidConfig(StytchUIInvalidConfiguration(stringResource(id = R.string.misconfigured_products_and_options)))
-        return
-    }
     Surface(
         modifier = modifier.fillMaxSize(),
         color = Color(LocalStytchTheme.current.backgroundColor),

diff --git a/source/sdk/src/main/res/values/strings.xml b/source/sdk/src/main/res/values/strings.xml
@@ -53,7 +53,6 @@
     <string name="cancel">Cancel</string>
     <string name="success">Success!</string>
     <string name="logged_in">You have successfully logged in.</string>
-    <string name="misconfigured_products_and_options">You must have at least one primary authentication factor (Passwords, EML, or Email OTP) enabled</string>
     <string name="hide_password">Hide password</string>
     <string name="show_password">Show password</string>
     <string name="strong_password">Great job! This is a strong password.</string>