Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "stylelint.reportDescriptionlessDisables" option #442

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

kizu
Copy link
Member

@kizu kizu commented Feb 12, 2023

Which issue, if any, is this issue related to?

Closes #441

Is there anything in the PR that needs further explanation?

Did in a way similar to other options, adding similar tests, adding it to the integration ones, and testing via running an extension development host:

Screenshot 2023-02-12 at 18 42 34

@ota-meshi
Copy link
Member

Thank you for this PR!

I don't think the failure of "Testing/Test on Node.js 14 and ubuntu-latest" is caused by this PR change. It will probably be fixed in #426, but it may not be fixed anytime soon.

However, it seems that the format of README.md is required. Could you run npm run format?

@kizu
Copy link
Member Author

kizu commented Feb 13, 2023

@ota-meshi Done!

@ota-meshi ota-meshi force-pushed the report-descriptionless-disables branch from 009c293 to a012214 Compare February 13, 2023 13:03
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 0d5b869 into stylelint:main Feb 14, 2023
@kizu kizu deleted the report-descriptionless-disables branch February 14, 2023 08:53
@jeddy3
Copy link
Member

jeddy3 commented Feb 14, 2023

@ota-meshi Thank you for reviewing and releasing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: add a stylelint.reportDescriptionlessDisables option
3 participants