Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up e2e tests #286

Closed
adalinesimonian opened this issue Oct 27, 2021 · 2 comments · Fixed by #318
Closed

Speed up e2e tests #286

adalinesimonian opened this issue Oct 27, 2021 · 2 comments · Fixed by #318
Assignees
@adalinesimonian
Labels
type: tests an improvement to testing
Milestone
v1.2.0

Comments

@adalinesimonian
Copy link
Member

adalinesimonian commented Oct 27, 2021 •
edited
Loading

Blocked by #271

e2e tests take a very long time. Some test suites could probably be thrown into the same workspace, not all tests should necessarily be running in a separate workspace — that would probably cut down times quite a bit.

Perhaps if #271 is taken care of, we might be able to start VS Code with multiple workspaces open and run tests in each workspace to avoid having to run a new instance of VS Code for each one. But that would require a bit more effort.
@adalinesimonian adalinesimonian added status: ready to implement is ready to be worked on by someone type: tests an improvement to testing labels Oct 27, 2021
@adalinesimonian adalinesimonian added this to the On Deck milestone Oct 27, 2021
adalinesimonian added a commit that referenced this issue Oct 27, 2021
@adalinesimonian
test: consolidate tests using extension defaults
77d004e 
Dramatically speeds up e2e tests.

Further work is needed:
#286
@adalinesimonian adalinesimonian mentioned this issue Oct 27, 2021
Merged
@adalinesimonian
Copy link
Member Author

Some test suites could probably be thrown into the same workspace, not all tests should necessarily be running in a separate workspace — that would probably cut down times quite a bit.

#287 does this where possible. Marking this issue as blocked on #271 for the rest of the speed-up effort.

@adalinesimonian adalinesimonian added status: blocked is blocked by another issue or pr and removed status: ready to implement is ready to be worked on by someone labels Oct 27, 2021
adalinesimonian added a commit that referenced this issue Nov 1, 2021
@adalinesimonian
test: consolidate tests using extension defaults (#287)
3ee6425 
Dramatically speeds up e2e tests.

Further work is needed:
#286
@adalinesimonian adalinesimonian modified the milestones: On Deck, v1.2.0 Nov 6, 2021
@adalinesimonian adalinesimonian linked a pull request Nov 8, 2021 that will close this issue
feat: resource-scoped configuration support #318
Merged
@adalinesimonian adalinesimonian self-assigned this Nov 8, 2021
@adalinesimonian adalinesimonian added Fixed and removed status: blocked is blocked by another issue or pr labels Nov 8, 2021
@adalinesimonian
Copy link
Member Author

Done in #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adalinesimonian adalinesimonian

Labels
type: tests an improvement to testing
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

feat: resource-scoped configuration support stylelint/vscode-stylelint
1 participant
@adalinesimonian