Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stylelint-config-two-dash-bem #75

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Add stylelint-config-two-dash-bem #75

merged 1 commit into from
Jun 23, 2024

Conversation

Darkzarich
Copy link
Contributor

Which issue, if any, is this issue related to?

None, as it's just adding a new thing to the list

Is there anything in the PR that needs further explanation?

No, it's self-explanatory

ybiquitous
ybiquitous requested changes Jun 22, 2024
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I didn't know the two dash style. Looks good 👍
Can you move the new entry in alphabetical order?

Edit: let's put it before the wikimedia config.

@Darkzarich
Copy link
Contributor Author

Darkzarich commented Jun 22, 2024 •
edited
Loading

Thank you!

Yes, sure, updated my commit with this change. Put it before the wikimedia config 👍

ybiquitous
ybiquitous approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍🏼

@ybiquitous ybiquitous merged commit 737e792 into stylelint:main Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darkzarich @ybiquitous