-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prettier for .md files #709
Conversation
(cherry picked from commit df050b8)
Looks like this Prettier issue is blocking this PR: prettier/prettier#3196 This doesn’t look good: <Button>Push Me</Button>; I was thinking about disabling semicolons in the docs but it has the opposite effect: ;<Button>Push Me</Button> |
I’m not even sure if it’s a bug of a feature so let’s see what they think. In the worst case I’ll disable all JSX examples manually and merge it. |
I’ve sent a PR to Prettier to fix that (it’s work in progress though), hope we could merge your PR soon! |
Codecov Report
|
I’ve updated Prettier, disabled semicolons and fixed several issues. Doc look good now. But we have to wait for another Prettier release with this fix: prettier/prettier#3401 |
I’ve updated Prettier again and now everything seems to work. |
Merged, thanks! |
fix #704