Skip to content

Update PlaygroundRenderer.js #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kulakowka
Copy link
Contributor

I want to suggest a change in the styles of the playground:

2017-04-08 22 47 52

Added transparent background
@codecov-io
Copy link

codecov-io commented Apr 8, 2017

Codecov Report

Merging #379 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #379   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          74       74           
  Lines        1038     1038           
  Branches      211      211           
=======================================
  Hits          973      973           
  Misses         65       65
Impacted Files Coverage Δ
...rc/rsg-components/Playground/PlaygroundRenderer.js 90.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b77970...0b11660. Read the comment docs.

@okonet
Copy link
Member

okonet commented Apr 10, 2017

I like the idea! But I think this should be customizable somehow. We might want to discuss features like this in #354

@kulakowka
Copy link
Contributor Author

@okonet It can be customized.

@n1313
Copy link
Collaborator

n1313 commented Apr 10, 2017

I have the same kind of background in my project as well, but it's diagonally striped. This one is also good.

@n1313
Copy link
Collaborator

n1313 commented Apr 10, 2017

Although to be honest, I am not sure if this is going to be useful for most people. This feature is useful if you are working on some sort of a reusable UI component library which is supposed to work in unpredictable conditions on variety of backgrounds. I doubt this is what the majority of RSG users are building. I think the majority is targeting one environment with a specific background color, and so will have little use for this change, and even might be annoyed by it. I think this change could be a perfect cookbook example of how to customise your RSG, or an optional extension in the future, but I'm not 100% sold on it being in the main repo.

@sapegin
Copy link
Member

sapegin commented Apr 11, 2017

Thanks for the pull request. I don’t think it’d be a good default. I agree with @n1313, would you mind sending a new pull request with a cookbook example?

@sapegin sapegin closed this Apr 11, 2017
kulakowka added a commit to kulakowka/react-styleguidist that referenced this pull request Apr 11, 2017
Update Playground background styleguidist#379
@kulakowka kulakowka mentioned this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants