-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken assetsDir due to updated copy-webpack-plugin #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because copy-webpack-pluign was updated, the assetsDir was broken. We need to update the config being passed to the plugin to make it work again. Update the plugin to latest version 6.1.0 and update the config and tests to make it work.
Error message was updated in code, but not in tests.
swashata
changed the title
WIP: Fix broken assetsDir
Fix broken assetsDir due to updated copy-webpack-plugin
Sep 8, 2020
Codecov Report
|
sapegin
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One tiny suggestion.
Since we don't have the latest types right now we have to cast to any. Once the types are released we can remove it. Co-authored-by: Artem Sapegin <[email protected]>
@sapegin Done. |
🎉 This PR is included in version 11.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Nov 10, 2020
Open
Open
Open
This was referenced Mar 7, 2021
Open
Open
This was referenced Sep 15, 2021
Open
Open
This was referenced Dec 25, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because copy-webpack-pluign was updated, the assetsDir was broken. We need to update the config being passed to the plugin to make it work again. Update the plugin to latest version 6.1.0 and update the config and tests to make it work.
copy-webpack-plugin
to^6.1.0
.copy-webpack-plugin
[make-webpack-config.ts:111
].highlightCode.spec.ts
so that build passes.Fixes #1676