Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Only highlight active page in TOC #1521

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Fix: Only highlight active page in TOC #1521

merged 4 commits into from
Jan 21, 2020

Conversation

elevatebart
Copy link
Collaborator

@elevatebart elevatebart commented Jan 15, 2020

vue-styleguidist/vue-styleguidist#689 (comment)

In my collapsible section PR I believe I have made one more mistake.

Before, only the current section was getting the selected flag. Now, all its parent do to. This is a fix for it. (see attached comment)

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #1521 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
...rsg-components/TableOfContents/TableOfContents.tsx 97.72% <100%> (ø) ⬆️

@elevatebart
Copy link
Collaborator Author

@sapegin do you think I could merge this one?

@sapegin sapegin merged commit 28398eb into master Jan 21, 2020
@sapegin sapegin deleted the fix-section-selected branch January 21, 2020 07:14
@sapegin
Copy link
Member

sapegin commented Jan 21, 2020

Sure, thanks!

@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 10.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants