Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Collapsible sections #1487

Merged
merged 31 commits into from
Jan 2, 2020
Merged

New: Collapsible sections #1487

merged 31 commits into from
Jan 2, 2020

Conversation

elevatebart
Copy link
Collaborator

@elevatebart elevatebart commented Dec 2, 2019

closes #1436

  • Make sections collapsible if you ask for it
    • tests
    • Document new option collapseSections
  • Adjust types in schema/config.ts (very minor) for sections
  • Add comments on unclear global types and simplify them

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #1487 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted Files Coverage Δ
src/client/utils/renderStyleguide.tsx 75% <ø> (ø) ⬆️
src/loaders/styleguide-loader.ts 95.23% <ø> (ø) ⬆️
src/client/rsg-components/Context/Context.ts 100% <ø> (ø) ⬆️
src/client/rsg-components/Link/LinkRenderer.tsx 100% <ø> (ø) ⬆️
...rc/client/rsg-components/StyleGuide/StyleGuide.tsx 75% <100%> (ø) ⬆️
...rsg-components/TableOfContents/TableOfContents.tsx 97.72% <100%> (+0.85%) ⬆️
src/client/utils/getRouteData.ts 97.82% <100%> (ø) ⬆️
src/client/utils/filterSectionsByName.ts 100% <100%> (ø) ⬆️
...t/rsg-components/ComponentsList/ComponentsList.tsx 100% <100%> (ø) ⬆️
...mponents/ComponentsList/ComponentsListRenderer.tsx 100% <100%> (ø) ⬆️
... and 4 more

@elevatebart elevatebart changed the title Feature: collapsible sections [WIP] Feature: Collapsible sections Dec 14, 2019
@elevatebart elevatebart changed the title Feature: Collapsible sections New: Collapsible sections Dec 14, 2019
@elevatebart elevatebart requested a review from sapegin December 15, 2019 16:44
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

docs/Configuration.md Outdated Show resolved Hide resolved
@elevatebart
Copy link
Collaborator Author

Hello @sapegin, do you think this Pull Request could be merged in?

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for slow review! Couple of minor suggestions ;-)

@elevatebart
Copy link
Collaborator Author

I took into account all of your comments.
@sapegin you have my green light to merge

@sapegin sapegin merged commit c1e25cf into master Jan 2, 2020
@sapegin sapegin deleted the feature-collapsible-sections branch January 2, 2020 13:11
@styleguidist-bot
Copy link
Collaborator

🎉 This PR is included in version 10.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section overview on large design systems.
3 participants