Accessibility fixes (to get accessibility validators for components usable) #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
Codecov Report
|
sapegin
pushed a commit
that referenced
this pull request
May 16, 2019
## New features
### Support React Hooks in examples
You can now use hooks in the examples, like the `useState` hook:
```jsx
const [count, setCount] = React.useState(42);
<Button onClick={() => setCount(count + 1)}>{count}</Button>
```
(#1353 by @eragon512)
## Bug fixes
* Accessibility fixes ([#1359](#1359) by @J-Kallunki)
* `getExampleFilename` should use default example if file does not exist ([#1362](#1362)) by @mendrew, closes [#1338](#1338)
* Hide HTML comments in Markdown files ([#1347](#1347) by @eragon512, closes #1326)
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using React-styleguidist to present and develop accessible components. Validation with Axe (React-Axe) shows error from the styleguidist so using validation tools becomes a bit harder.
Here's fixes to get accessibility validation (Axe) to pass.
Part of it is PR to Mini-html-webpack-plugin to have lang-attribute for html-element:
styleguidist/mini-html-webpack-plugin#8