Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds inline-scroll on props-table #1131

Merged
merged 7 commits into from
Sep 11, 2018
Merged

adds inline-scroll on props-table #1131

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
07e8795
fix: allows pathline to wrap
derz Sep 3, 2018
35ee9b6
fix: inline-scroll on tab-body (table gets too wide on mobile)
derz Sep 6, 2018
7867818
Merge branch 'master' of https://github.com/styleguidist/react-styleg…
derz Sep 7, 2018
03f2611
Merge branch 'master' of https://github.com/styleguidist/react-styleg…
derz Sep 7, 2018
3665324
Merge branch 'master' into feature/table-overflow
derz Sep 7, 2018
9bdb2dc
refactoring: camelCase css
derz Sep 11, 2018
5b2b661
chore: updates ReactComponent snapshot
derz Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/rsg-components/ReactComponent/ReactComponentRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ const styles = ({ color, fontSize, space }) => ({
tabButtons: {
marginBottom: space[2],
},
tabBody: {
overflowX: 'auto',
maxWidth: '100%',
'-webkit-overflow-scrolling': 'touch',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will WebkitOverflowScrolling work too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, yes. :-) However it is the same as here:

react-styleguidist/src/rsg-components/StyleGuide/StyleGuideRenderer.js

Line 40 in b66bd10

'-webkit-overflow-scrolling': 'touch',
- but I am not super into styled-components, so I don't really know what's the intended way to do it. Btw.: Thanks for your great work on it so far!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both should work the same way, camelCased one is just more idiomatic, because all other attributes are camelCased.

It's JSS, not styled-components by the way ;-)

},
docs: {
color: color.base,
fontSize: fontSize.text,
Expand Down Expand Up @@ -48,7 +53,7 @@ export function ReactComponentRenderer({
{tabButtons && (
<div className={classes.tabs}>
<div className={classes.tabButtons}>{tabButtons}</div>
{tabBody}
<div className={classes.tabBody}>{tabBody}</div>
</div>
)}
{examples}
Expand Down