Fix(config): better resolving of components on windows

[elevatebart]

No description provided.

[sapegin]

Thanks for the PR! Could you please explain your solution?

[elevatebart]

Absolutely,

The diagnosis is simple: glob.sync("src/@{components,Components}/**/*.js") returns each component file twice on windows since it is case insensitive. It is probably a bug on glob.
In order not to be impacted by this bug or limitation, I make the matching case insensitive. Case is actually never matched on windows anyway.
To avoid disturbing other OSs, I only ignore it on windows.

To avoid having to write the fix twice, I changed the code a little for it to be a little more DRY.

I hope I did not mess too much with the philosophy.
I am open to suggestions.

[sapegin]

nocase Perform a case-insensitive match. Note: on case-insensitive filesystems, non-magic patterns will match by default, since stat and readdir will not raise errors.

If I understand this correctly, it's case-insensitive on Windows in any case, so your fix is likely relying on some filtering they do when this flag is enabled. Probably we should report it to glob as well.

[sapegin]

A few minor comments, otherwise looks good!

[codecov-io]

Codecov Report

Merging #1128 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files	Coverage Δ
loaders/utils/getComponentFiles.js	100% <100%> (ø)	⬆️

[elevatebart]

@sapegin Thank you for the feedback. I think I will definitely send a Request to glob to understand better this behaviour. It seems shady.
I took your comments into account and pushed a new version hope you like it.

[sapegin]

Thanks, one last thing ;-)

[elevatebart]

Done ;)

[styleguidist-bot]

🎉 This PR is included in version 7.3.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀