Skip to content

input::placeholder selector breaks display in Chrome 55 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n1313 opened this issue Jun 12, 2017 · 1 comment
Closed

input::placeholder selector breaks display in Chrome 55 #491

n1313 opened this issue Jun 12, 2017 · 1 comment
Assignees
Labels

Comments

@n1313
Copy link
Collaborator

n1313 commented Jun 12, 2017

Some elements of UI are looking weird in Chrome 55 (Windows) because of this input::placeholder selector. It should either be vendor-prefixed or separated from the rest.

@sapegin sapegin added the bug label Jun 12, 2017
@sapegin
Copy link
Member

sapegin commented Jun 12, 2017

The problem is that it breaks jss-isolate, because that unsupported in Chrome 55 pseudo element discards the whole jss-isolate selector:

… .input-0-68, .input-0-68::placeholder, .list-0-71 … {}

So we need to disable isolation for rules with ``:

'&::placeholder': {
  isolate: false
  // ...
}

@n1313 n1313 self-assigned this Jun 21, 2017
sapegin added a commit that referenced this issue Jun 28, 2017
## New features

### Copy pathline to clipboard button

![](http://wow.sapegin.me/3t2u3S0P0L2T/Image%202017-06-28%20at%204.17.16%20PM.png)

(#485, #471 by @SaraVieira)

### Easier way to override style guide React components

New config option `styleguideComponents` to override React components used to render a style guide.

```javascript
module.exports = {
	styleguideComponents: {
		Logo: path.join(__dirname, 'styleguide/components/Logo'),
		StyleGuideRenderer: path.join(__dirname, 'styleguide/components/StyleGuide'),
	},
};
```

(#504)

### Customizable logging

New `logger` option:

```javascript
module.exports = {
	logger: {
    // One of: info, debug, warn
    // Suppress messages
		info: () => {},
    // Override display function
		warn: message => console.warn(`NOOOOOO: ${message}`),
	},
};
```

(#472, #510)

## Bug fixes

* Allow `devServer.watchConfig` to be configured, this also means Vagrant is now supported (#515, #516 by @esphen)
* Default `getExampleFilename` should be case-insensitive (#423, #460, #440, #482)
* Allow dynamic JSS styles
* Isolate search placeholder styles (#509, #491 by @n1313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants