Skip to content

Commit

Permalink
Fix: use fast-glob instead of glob
Browse files Browse the repository at this point in the history
This fixes issues on windows

Closes #1132
  • Loading branch information
Barthelemy Ledoux committed Sep 11, 2018
1 parent 1c44a84 commit fb90cd3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
4 changes: 2 additions & 2 deletions loaders/utils/getComponentFiles.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const path = require('path');
const glob = require('glob');
const glob = require('fast-glob');
const isFunction = require('lodash/isFunction');
const isString = require('lodash/isString');

Expand All @@ -19,7 +19,7 @@ const getComponentGlobs = components => {
const getFilesMatchingGlobs = (components, rootDir, ignore) =>
components
.map(listItem =>
glob.sync(path.resolve(rootDir, listItem), {
glob.sync(listItem, {
cwd: rootDir,
ignore,
})
Expand Down
18 changes: 6 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
"es6-object-assign": "~1.1.0",
"es6-promise": "^4.2.4",
"escodegen": "^1.10.0",
"fast-glob": "^2.2.2",
"findup": "^0.1.5",
"function.name-polyfill": "^1.0.6",
"github-slugger": "^1.2.0",
"glob": "^7.1.2",
"glogg": "^1.0.1",
"highlight.js": "^9.12.0",
"is-directory": "^0.3.1",
Expand Down

0 comments on commit fb90cd3

Please sign in to comment.