Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Inline globals.css like the rest of the CSS #1039

Merged
merged 2 commits into from
Apr 19, 2024
Merged

chore: Inline globals.css like the rest of the CSS #1039

merged 2 commits into from
Apr 19, 2024

Conversation

XhmikosR
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 16, 2024

@XhmikosR is attempting to deploy a commit to the Package Phobia Team on Vercel.

A member of the Team first needs to authorize it.

@XhmikosR
Copy link
Contributor Author

BTW it seems we have #445 so we can tackle moving inline CSS to an external file later, assuming cache busting + proper cache headers are implemented.

Otherwise it doesn't make a lot of sense IMHO to have a CSS file with just 2 rules.

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
packagephobia ✅ Ready (Inspect) Visit Preview Apr 19, 2024 9:20pm

Copy link
Owner

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for the time being

@XhmikosR XhmikosR marked this pull request as ready for review April 17, 2024 18:47
@styfle styfle enabled auto-merge (squash) April 19, 2024 21:18
@styfle styfle merged commit d0b694b into styfle:main Apr 19, 2024
3 of 4 checks passed
@XhmikosR XhmikosR deleted the xmr/inline-css branch April 20, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants