Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old IE and Edge icons #1036

Merged
merged 1 commit into from
Apr 17, 2024
Merged

chore: remove old IE and Edge icons #1036

merged 1 commit into from
Apr 17, 2024

Conversation

XhmikosR
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 16, 2024

@XhmikosR is attempting to deploy a commit to the Package Phobia Team on Vercel.

A member of the Team first needs to authorize it.

@XhmikosR XhmikosR marked this pull request as ready for review April 16, 2024 15:08
@@ -147,7 +147,6 @@ export async function renderPage(
<link rel="icon" href="/favicon-16x16.png" sizes="16x16" type="image/png">
<link rel="manifest" href="/site.webmanifest">
<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#33aa33">
<meta name="msapplication-TileColor" content="#333333">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this used for pinning to desktop on Windows, not necessary just Edge

https://stackoverflow.com/q/61686919/266535

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link you shared only mentions Windows 8 and IE, both of which are no more, though.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Owner

@styfle styfle Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it on different versions of windows? There's a preview url here https://packagephobia-git-fork-xhmikosr-xmr-rm-old-icons-packagephobia.vercel.app

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any difference because it only affected Windows 8/8.1 and or IE which are dead :)

image

Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
packagephobia ✅ Ready (Inspect) Visit Preview Apr 16, 2024 9:06pm

@styfle styfle merged commit 2f759e5 into styfle:main Apr 17, 2024
4 checks passed
@XhmikosR XhmikosR deleted the xmr/rm-old-icons branch April 17, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants