Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some spacing between sponsors #1016

Closed
1 task
MathurAditya724 opened this issue Oct 30, 2023 · 5 comments · Fixed by #1020
Closed
1 task

Add some spacing between sponsors #1016

MathurAditya724 opened this issue Oct 30, 2023 · 5 comments · Fixed by #1020

Comments

@MathurAditya724
Copy link
Contributor

MathurAditya724 commented Oct 30, 2023

  • Add even spacing between them
image
@MathurAditya724
Copy link
Contributor Author

I will create a PR, once #1015 is merged

@styfle
Copy link
Owner

styfle commented Oct 31, 2023

Don't worry about this one. I am planning to drop Upstash now that Vercel has its own storage offering

https://vercel.com/blog/vercel-storage

In fact, I'll probably switch from Redis to Postgres which is better suited for these types of queries.

@MathurAditya724
Copy link
Contributor Author

That's great, but it really gives me an OCD attack when I come to your site 🙃. And I have already prepared the code, so can you please accept the PR, later? 🤞🏼

@MathurAditya724
Copy link
Contributor Author

Don't worry about this one. I am planning to drop Upstash now that Vercel has its own storage offering

https://vercel.com/blog/vercel-storage

In fact, I'll probably switch from Redis to Postgres which is better suited for these types of queries.

Btw have you started working on this? I would love to contribute to it

@styfle
Copy link
Owner

styfle commented Nov 2, 2023

I haven’t started yet. I think the most challenging part will be creating a semver ORDER BY so that we don’t need to sort in JS and therefore minimize the result returned from the query. I haven’t researched if this is possible yet.

@styfle styfle linked a pull request Nov 11, 2023 that will close this issue
1 task
styfle pushed a commit that referenced this issue Nov 11, 2023
Resolved Issue #1016 

- [x] added some margin above each sponsor component to make them evenly
spaced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants