Fix: Make Non-Static Method Not Static; Globalize WP_Term_Order
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1. Make Non-Static Method Not Static
WP_Term_Order::term_order_add_form_field()
method is declared as a static method, but only ever used in a non-static object context.static
method from that method declaration.2. Globalize
WP_Term_Order
remove_action()
. This is bad practice for a WordPress plugin or theme, and should be fixed.WP_Term_Order
class.init
hook callback) a global variable:global $wp_term_order
.remove_action()
calls, without otherwise affecting any existing plugin functionality.