Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetix support #64

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Synthetix support #64

merged 6 commits into from
Jun 24, 2020

Conversation

marcelomorgado
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Jun 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/study-defi/money-legos/m4x6bri2f
✅ Preview: https://money-legos-git-fork-marcelomorgado-synthetix-support.study-defi.vercel.app

@adrianmcli
Copy link
Member

wow @marcelomorgado great stuff again! I'll review this soon

adrianmcli
adrianmcli approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@adrianmcli adrianmcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/utils.ts
export const mineBlock = async (provider: any, timestamp: number) =>
await provider.send("evm_mine", [timestamp]);

export const increaseTime = async (provider: any, secsToIncrease: number) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool. We should probably publish this kind of stuff.

@adrianmcli
Copy link
Member

@marcelomorgado looks like there's a conflict w/ kyber.test.ts. Do you think you can fix that?

@adrianmcli adrianmcli merged commit a8905e9 into studydefi:master Jun 24, 2020
@marcelomorgado
Copy link
Collaborator Author

@marcelomorgado looks like there's a conflict w/ kyber.test.ts. Do you think you can fix that?

Hi @adrianmcli, is it still an issue?

@adrianmcli
Copy link
Member

@marcelomorgado looks like there's a conflict w/ kyber.test.ts. Do you think you can fix that?

Hi @adrianmcli, is it still an issue?

Nope, I fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmcli adrianmcli adrianmcli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcelomorgado @adrianmcli