Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/import pages #194

Merged
merged 7 commits into from
Mar 8, 2019
Merged

Feature/import pages #194

merged 7 commits into from
Mar 8, 2019

Conversation

dreamwhisper
Copy link
Contributor

@dreamwhisper dreamwhisper commented Mar 7, 2019 •
edited
Loading

  • Adds About, Contact, Landing, and Block Examples Pages to import
  • Adds images for use on About and Landing page
  • Adds 5 menu items to Primary menu
  • Adds additional Plugins to install and activate

Notes:

  • The ability to set the layout will be available in a future release. For this reason, the block template is used for About and Block Examples.
  • PR based on Feature/template folder #193

Addresses #184 #185

@dreamwhisper dreamwhisper requested a review from nickcernis March 7, 2019 20:36
@dreamwhisper dreamwhisper added this to the Genesis Sample 2.9.0 milestone Mar 7, 2019
@nickcernis
Copy link
Collaborator

nickcernis commented Mar 8, 2019 •
edited
Loading

@dreamwhisper I added the Atomic Blocks public_url and removed the post_name key for the homepage. This otherwise looks good to release from draft and merge, though. (I can't seem to change its status from draft; guessing only the PR author can do that.)

@nickcernis
Remove post_name key and value
e46fa44 
This is no longer needed in Genesis 2.9+, as WordPress generates the
slug automatically from the title.
@dreamwhisper dreamwhisper marked this pull request as ready for review March 8, 2019 13:14
@dreamwhisper dreamwhisper merged commit 36042fa into develop Mar 8, 2019
@dreamwhisper dreamwhisper deleted the feature/import-pages branch March 8, 2019 13:25
This was referenced Mar 8, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickcernis nickcernis Awaiting requested review from nickcernis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Genesis Sample 2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamwhisper @nickcernis