Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove '/contact' links from homepage onboarding content #181

Closed
nickcernis opened this issue Jan 16, 2019 · 2 comments
Closed

Remove '/contact' links from homepage onboarding content #181

nickcernis opened this issue Jan 16, 2019 · 2 comments
Assignees
@dreamwhisper
Labels
enhancement good first issue has-pr
Milestone
Genesis Sample 2.9.0

Comments

@nickcernis
Copy link
Collaborator

nickcernis commented Jan 16, 2019 •
edited
Loading

Homepage onboarding content features relative links to a /contact URL, such as this one:

genesis-sample/config/import/content/homepage.php

Line 89 in 71e85dd

<div class="wp-block-button alignright is-style-outline"><a class="wp-block-button__link" href="/contact">Get in touch</a></div>

Even though these links are intended to be replaced by site owners, we should replace them in demo content with # so they don't 404.
@nickcernis nickcernis added this to the Genesis Sample 2.8.1 milestone Jan 16, 2019
@dreamwhisper
Copy link
Contributor

@nickcernis It's just the one link, correct? I think the others are all #.

@nickcernis
Copy link
Collaborator Author

@dreamwhisper This one too:

genesis-sample/config/import/content/homepage.php

Line 111 in 71e85dd

<p>You can reach us on our <a href="/contact">contact page</a> or by calling us at 1.123.456.7891</p>

dreamwhisper added a commit that referenced this issue Mar 7, 2019
@dreamwhisper
Remove '/contact' links from homepage onboarding content
a74c9c2 
fixes #181
@dreamwhisper dreamwhisper mentioned this issue Mar 7, 2019
Merged
@dreamwhisper dreamwhisper self-assigned this Mar 7, 2019
@dreamwhisper dreamwhisper modified the milestones: Genesis Sample 2.8.1, Genesis Sample 2.9.0 Mar 7, 2019
nickcernis pushed a commit that referenced this issue Mar 8, 2019
@dreamwhisper @nickcernis
Remove '/contact' links from homepage onboarding content
41c7930 
fixes #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamwhisper dreamwhisper

Labels
enhancement good first issue has-pr
Projects
None yet
Milestone
Genesis Sample 2.9.0
Development

No branches or pull requests
2 participants
@nickcernis @dreamwhisper