-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add a Carousel component #320
Open
titouanmathis
wants to merge
2
commits into
develop
Choose a base branch
from
feature/carousel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export Size@studiometa/ui
Unchanged@studiometa/ui
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #320 +/- ##
===========================================
- Coverage 80.35% 79.38% -0.97%
===========================================
Files 96 106 +10
Lines 3298 3570 +272
Branches 324 332 +8
===========================================
+ Hits 2650 2834 +184
- Misses 648 736 +88
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
To replace the Slider component with native scroll-snap for touch devices.
titouanmathis
force-pushed
the
feature/carousel
branch
from
November 18, 2024 09:44
187ef76
to
121132e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To replace the Slider component with native scroll-snap for touch devices.
π Linked issue
No issue.
β Type of change
π Description
This PR adds a new Carousel component which aims to replace the existing Slider component.
It aims to be more minimalist by using scroll-snapping on touch device instead of handling drag and drop in JS.
Playground
To-do
π Checklist