Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige le problème d'index des slides créant un décalage avec la nav #289

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Guilm
Copy link

@Guilm Guilm commented Aug 8, 2024

@perruche @titouanmathis,

j'ai implémenté un fix qu'on implémente tout le temps sur les projets.

Ça me semble OK niveau implémentation, cependant je ne suis pas spécialisé dans typescript et je ne sais pas comment tester tout ça !

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

github-actions bot commented Aug 8, 2024

Export Size

@studiometa/ui

Name Size Diff
Slider 2.29 kB +17 B (+0.75%) 🔺
SliderBtn 2.65 kB +19 B (+0.72%) 🔺
AbstractSliderChild 2.49 kB +17 B (+0.69%) 🔺
SliderDots 2.74 kB +14 B (+0.51%) 🔺
SliderProgress 2.56 kB +9 B (+0.35%) 🔺
MOLECULES 7.15 kB +14 B (+0.20%) 🔺
SliderCount 2.51 kB +4 B (+0.16%) 🔺
ALL 12.72 kB +4 B (+0.03%) 🔺
Unchanged

@studiometa/ui

Name Size Diff
AbstractPrefetch 411 B -
AbstractScrollAnimation 461 B -
Accordion 1.06 kB -
AccordionItem 1.03 kB -
Action 648 B -
AnchorNav 616 B -
AnchorNavLink 485 B -
AnchorNavTarget 207 B -
AnchorScrollTo 249 B -
animationScrollWithEase 272 B -
ATOMS 5.15 kB -
CircularMarquee 339 B -
Cursor 665 B -
DataBind 671 B -
DataComputed 811 B -
DataEffect 778 B -
DataModel 745 B -
Draggable 327 B -
Figure 694 B -
FigureTwicpics 1.15 kB -
FigureVideo 983 B -
FigureVideoTwicpics 1.48 kB -
Frame 1.69 kB -
FrameAnchor 201 B -
FrameForm 198 B -
FrameTarget 777 B -
LargeText 492 B -
LazyInclude 422 B -
loadImage 694 B -
Menu 1.37 kB -
MenuBtn 235 B -
MenuList 943 B -
Modal 898 B -
ModalWithTransition 1.01 kB -
ORGANISMS 1.75 kB -
Panel 1.25 kB -
PrefetchWhenOver 468 B -
PrefetchWhenVisible 480 B -
PRIMITIVES 632 B -
ScrollAnimation 513 B -
ScrollAnimationChild 650 B -
ScrollAnimationChildWithEase 851 B -
ScrollAnimationParent 712 B -
ScrollAnimationWithEase 711 B -
ScrollReveal 622 B -
Sentinel 217 B -
SliderDrag 358 B -
SliderItem 733 B -
Sticky 866 B -
TableOfContent 744 B -
TableOfContentAnchor 552 B -
Tabs 633 B -
Target 189 B -
Transition 387 B -

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (3f7adfc) to head (e99a41e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #289      +/-   ##
===========================================
+ Coverage    77.37%   77.47%   +0.09%     
===========================================
  Files           91       91              
  Lines         3165     3179      +14     
  Branches       272      272              
===========================================
+ Hits          2449     2463      +14     
  Misses         716      716              
Flag Coverage Δ
unittests 77.47% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants