Accounts.onCreateUser issue

[SachaG]

You can only have a single callback hook on Accounts.onCreateUser, which leads to the following warning:

You've implemented Accounts.onCreateUser elsewhere in your application, you can therefor not use Accounts.ui.config({ onPostSignUpHook }) on the server.

What if instead of showing that warning, accounts-ui simply extended the current callback (available at Accounts._onCreateUserHook) with its own custom logic?

i.e.

Accounts.onCreateUser(() => {
  Accounts._onCreateUserHook();
  // do custom stuff here
}

[timbrandin]

I've made it so that it doesn't warn unless you actually use the hook,
https://github.com/studiointeract/accounts-ui/blob/master/imports/api/server/onPostSignUpHook.js#L1

But I guess you mean we make it possible to have multiple onCreateUser() in an application, wouldn't that be better if this solution came from accounts-base instead? 💃

[SachaG]

Yeah either one these three solutions (only warn if the hook if used, run both the hook and the original callback, fix the problem at the root) works for me, since I'm not using the hook anyway :)

[timbrandin]

Alright, would it be a big issue if removed the serverside version of the hook? Just now it's causing more issues than it is solving, when one already can use onCreateUser for the same thing, maybe just document how to do this in the Readme without and then remove the hook?

[SachaG]

Sounds good to me.

[timbrandin]

https://github.com/studiointeract/accounts-ui/releases/tag/release-1.1.6