fix(js-types-auth): Replace builder with Vite and add session type #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbenTesara
added
bug
IbenTesara
requested review from
DenisValcke,
WHeirstrate,
jsprds and
reunefe
jsprds
approved these changes
Jan 30, 2025
DenisValcke
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the package in the Angular lib resulted in issues which pointed towards the build. By moving from Esbuild to Vite the issues seemed to have resolved. Doing so automatically updated vite for each project, which still run.
Additionally, a session type can now be passed to the AuthenticationResponse
Requirements