feat(js-types-auth): Setup authentication types package #389
Conversation
IbenTesara
added
setup
IbenTesara
requested review from
DenisValcke,
WHeirstrate,
bertyhell and
reunefe
IbenTesara
force-pushed
the
feat/javascript/types/auth/setup
branch
from
2f1b6dd to
999a383
Compare
|
@IbenTesara can you give more information about the Verdaccio setup? 🙏 |
It's something that was auto-generated by Nx, we used it in the previous repos as well but I don't have that much more insight in it I'm afraid 😅 |
IbenTesara
force-pushed
the
feat/javascript/types/auth/setup
branch
from
999a383 to
81c5830
Compare
There was a problem hiding this comment.
Could you illustrate what purpose this authentication package serves? I assume this is part 1 of many to create a plug-and-play authentication service that communicates between a node backend and a frontend? Will this be framework agnostic, or catered to Angular?
| "@studiohyperdrive/env": "1.0.4", | ||
| "@studiohyperdrive/utils": "^2.0.0", | ||
| "@studiohyperdrive/ngx-core": "19.1.0", | ||
| "@studiohyperdrive/utils": "^2.0.0", |
There was a problem hiding this comment.
Why don't we use a fixed versioning here?
There was a problem hiding this comment.
This isn't part of the scope of this PR nor was it added by me; but I see nothing wrong with this not being a fixed version.
We're responsible for that package, ergo we should take responsibility to ensure that we can keep working with this approach instead of setting it on a fixed version and updating it with every minor release we do for the utils package. 🤷
There was a problem hiding this comment.
I missed the fact that you moved this line down. I though you had added this, my bad.
Honestly I don't see how much more information I can give than the one in the docs 😅 This is indeed a framework agnostic types package, so both the frontend packages and the backend packages or backends that want to link with the frontend packages can use these types. The end goal is to have a frontend package for each framework, making it so that we can easily handle permissions, feature flags, and user authentication in a consistent way :) |
IbenTesara
force-pushed
the
feat/javascript/types/auth/setup
branch
from
81c5830 to
1d173bf
Compare
| "@studiohyperdrive/env": "1.0.4", | ||
| "@studiohyperdrive/utils": "^2.0.0", | ||
| "@studiohyperdrive/ngx-core": "19.1.0", | ||
| "@studiohyperdrive/utils": "^2.0.0", |
There was a problem hiding this comment.
I missed the fact that you moved this line down. I though you had added this, my bad.
Description
Sets up a library with shared authentication types that we can later use in shared authentication frontend packages
Requirements