feat(ngx-layout): Add image-marker component #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbenTesara
added
enhancement
IbenTesara
requested review from
DenisValcke,
WHeirstrate,
ekincia and
reunefe
IbenTesara
commented
Jan 16, 2025
| "@js/testing": ["libs/javascript/testing/src/index.ts"], | ||
| "@express/status": ["libs/express/status/src/index.ts"], | ||
| "@studiohyperdrive/ngx-core": ["libs/angular/core/src/index.ts"] | ||
| "@ngx/core": ["libs/angular/core/src/index.ts"] |
There was a problem hiding this comment.
This needed to be changed, as otherwise we can't depend on the published ngx-core package.
reunefe
reviewed
Jan 16, 2025
| The `stateUpdated` Output will emit whenever a change has been made to the annotations during edit mode, whilst `markerClicked` will emit whenever a marker is clicked during view mode. | ||
|
|
||
| Additionally, we can pass a set of `markerTypes` we want the MarkerJs package to be restricted to. It's important to know that we need to provide markers for both the view and the edit mode, given they both use different packages and interfaces; being `marker-live` and `markerjs2` respectively. | ||
|
|
There was a problem hiding this comment.
Would be nice if a small demo could be provided here
apps/docs/src/app/pages/docs/angular/layout/implementation/components/index.md
Outdated
Show resolved
Hide resolved
apps/docs/src/app/pages/docs/angular/layout/implementation/components/index.md
Outdated
Show resolved
Hide resolved
apps/docs/src/app/pages/docs/angular/layout/implementation/components/index.md
Outdated
Show resolved
Hide resolved
libs/angular/layout/src/lib/components/image-marker/image-marker.component.ts
Outdated
Show resolved
Hide resolved
libs/angular/layout/src/lib/components/image-marker/image-marker.component.ts
Outdated
Show resolved
Hide resolved
libs/angular/layout/src/lib/components/image-marker/image-marker.component.ts
Show resolved
Hide resolved
libs/angular/layout/src/lib/services/image-marker/image-marker.service.ts
Show resolved
Hide resolved
3 tasks
IbenTesara
force-pushed
the
feat/angular/ngx-layout/image-marker
branch
from
f6c3855 to
0d8efd4
Compare
IbenTesara
force-pushed
the
feat/angular/ngx-layout/image-marker
branch
from
0d8efd4 to
49bf479
Compare
WHeirstrate
reviewed
Jan 20, 2025
libs/angular/layout/src/lib/components/image-marker/image-marker.component.ts
Show resolved
Hide resolved
libs/angular/layout/src/lib/components/image-marker/image-marker.component.ts
Show resolved
Hide resolved
libs/angular/layout/src/lib/components/image-marker/image-marker.component.ts
Show resolved
Hide resolved
libs/angular/layout/src/lib/services/image-marker/image-marker.service.ts
Show resolved
Hide resolved
WHeirstrate
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an Angular wrapper to MarkerJs2 and Marker-Live.
Requirements
Attachments
