fix(ngx-table): make the sorting table header cell a button to improve accessibility #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHeirstrate
added
bug
IbenTesara
approved these changes
Oct 9, 2024
WHeirstrate
force-pushed
the
fix/ngx-table/wcag-table-header-compliancy
branch
from
1ca8e9d to
c18d865
Compare
WHeirstrate
commented
Oct 9, 2024
| | ngx-table-row-cel | A class added to all row cells in the table | | ||
| | ngx-table-footer-cell | A class added to all footer cells in the table | | ||
| | ngx-table-selectable-cell | A class added to all selectable cells in the table | | ||
| | ngx-table-sorting-cell-button | A class added to the button that is generated around the content of each sortable cell | |
There was a problem hiding this comment.
I only added this line, the others are formatting for my OCD
WHeirstrate
force-pushed
the
fix/ngx-table/wcag-table-header-compliancy
branch
from
c18d865 to
fd0d841
Compare
IbenTesara
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-10-09.at.11.01.21.mov