feat(ngx-table): Make the table accessible through the tree-grid pattern #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbenTesara
added
enhancement
IbenTesara
force-pushed
the
feat/ngx-table/add-aria-compliance-to-ngxtable
branch
from
626b876 to
fbc80d5
Compare
WHeirstrate
requested changes
Sep 25, 2024
libs/table/src/lib/directives/tree-grid/tree-grid.cell.directive.ts
Outdated
Show resolved
Hide resolved
IbenTesara
force-pushed
the
feat/ngx-table/add-aria-compliance-to-ngxtable
branch
from
fbc80d5 to
cb2990a
Compare
WHeirstrate
approved these changes
Sep 25, 2024
DenisValcke
reviewed
Sep 26, 2024
libs/table/src/lib/directives/tree-grid/tree-grid-row.directive.ts
Outdated
Show resolved
Hide resolved
libs/table/src/lib/directives/tree-grid/tree-grid.cell.directive.ts
Outdated
Show resolved
Hide resolved
libs/table/src/lib/directives/tree-grid/tree-grid.cell.directive.ts
Outdated
Show resolved
Hide resolved
IbenTesara
force-pushed
the
feat/ngx-table/add-aria-compliance-to-ngxtable
branch
from
cb2990a to
e1865a6
Compare
IbenTesara
force-pushed
the
feat/ngx-table/add-aria-compliance-to-ngxtable
branch
from
e1865a6 to
c86276d
Compare
DenisValcke
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds WCAG compliance through the treegrid pattern.
Some form of Cypress/other related testing should be added in the future to properly test the keyboard interactions.