Skip to content

fix(modal.service): verify the subject is not undefined when checking if a modal exists #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(modal.service): verify the subject is not undefined when checking if a modal exists #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/inform/src/lib/services/modal/modal.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export class NgxModalService {
public open<ActionType extends string = string, DataType = any>(
options: NgxModalOptions<ActionType, DataType>
): Observable<ActionType> {
// Iben: If there still is an active subject running, the modal is still active and we early exit
if (!this.modalClosedSubject?.closed) {
// Iben: If there still is an active subject running, the modal is still active and we early exit.
if (this.modalClosedSubject !== undefined && !this.modalClosedSubject?.closed) {
console.warn(
'NgxInform: An active modal is currently displayed, close the active modal before opening a new one'
);
Expand Down