fix(ngx-i18n): Add initializeLanguage #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbenTesara
added
bug
DenisValcke
reviewed
Sep 12, 2024
DenisValcke
reviewed
Sep 12, 2024
DenisValcke
approved these changes
Sep 12, 2024
IbenTesara
force-pushed
the
fix/ngx-i18n/i18n-guard
branch
from
6378eeb to
677adcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SetLanguageGuard takes care of initializing the language when no language was set and this works perfectly when the language is not part of the route yet.
However, when the language parameter was already set, the guard is not called and the I18nGuard did not initialize the language. This PR fixes the issue.