Skip to content

feat(ngx-i18n): Make the package cohesive with other packages and add SetLanguageGuard #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat(ngx-i18n): Make the package cohesive with other packages and add SetLanguageGuard #216

merged 1 commit into from
Sep 12, 2024

Conversation

@IbenTesara
Copy link
Contributor

@IbenTesara IbenTesara commented Sep 11, 2024

This PR does two things.

  1. It renames the services, guards, etc. to be more cohesive with the other packages. Now it is clear they're part of the ngx-i18n package. I at first wanted to write a migration script, but unfortunately did not have the time.
  2. It adds a new guard that will automatically set the language
  3. It makes the root I18nService clearer

@IbenTesara IbenTesara added enhancement New feature or request ngx-i18n @studiohyperdrive/ngx-i18n labels Sep 11, 2024
@IbenTesara IbenTesara added this to the ngx-i18n:v18.1.0 milestone Sep 11, 2024
@IbenTesara IbenTesara self-assigned this Sep 11, 2024
@IbenTesara IbenTesara merged commit 170c862 into master Sep 12, 2024
@IbenTesara IbenTesara deleted the feat/ngx-i18n/guard branch September 12, 2024 05:32
@IbenTesara IbenTesara linked an issue Sep 12, 2024 that may be closed by this pull request
Any translation path will be accepted by the NgxI18nModule #183
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenisValcke DenisValcke DenisValcke approved these changes

@WHeirstrate WHeirstrate Awaiting requested review from WHeirstrate

@ekincia ekincia Awaiting requested review from ekincia

Assignees

@IbenTesara IbenTesara

Labels

enhancement New feature or request ngx-i18n @studiohyperdrive/ngx-i18n

Projects

None yet

Milestone

ngx-i18n:v18.1.0

Development

Successfully merging this pull request may close these issues.

Any translation path will be accepted by the NgxI18nModule

3 participants

@IbenTesara @DenisValcke