Merged
Conversation
stuartbfox
force-pushed
the
per_env_vars
branch
from
df9d54b to
f4325a1
Compare
…yment system * Per stack naming (`--stack-name=blah`) * Per stack environment files (`--vars-file=/path/to/vars/file.yaml`) * Variable amounts of nodes (`--master-instance-count=3 --infra-instance-count=2 --node-instance-count=2`) with sensible defaults and limits ** masters min 3 max 10 ** infra min 3 max 10 ** node min 2 max 100 * Jinjify the json templates * JSON cleanup * Inclusion of CFN snippets to extend stack functionality (`--custom-template=/path/to/custom/template.json` or `--custom-template=/path/to/custom/template.json.j2`) * Leave the default auth schema github but add a commented out section to enable basic http_auth admin/admin
stuartbfox
force-pushed
the
per_env_vars
branch
from
f4325a1 to
6827d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just pull from your master and notice you've added scaling by calling a playbook. I took a different approach by adding cli arguments (--master-instance-count --infra-instance-count --node-instance count) and letting ose-on-aws.py take care of it. I've tested many times and it works.
Other major features :-
Stack naming
Propagate stack_name everywhere so you can have multiple stacks per region
Per environment vars file
Separate vars_file per env, maybe you want smaller instance types for a dev cluster
Scaling
See above
Jinjifying the cfn templates
Required by the scaling work
Ability to merge additional cfn features into the main cfn template.
My use case is to deploy rds instances into the same stack.