Show link to docs on a build

stsewd · Dec 23, 2017 · e54401d · e54401d
1 parent 9bcb5fb
commit e54401d
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 49 deletions.
diff --git a/readthedocs/builds/static/builds/css/detail.css b/readthedocs/builds/static/builds/css/detail.css
@@ -1,38 +1,34 @@
 /* Build detail styles */
 
-div.build-detail div.build-id {
-    font-size: 1.5em;
+div.build-detail div.build-title {
+    margin: .1em 0em .2em 0em;
 }
 
-div.build-detail div.build-version {
-    line-height: 2em;
+div.build-detail div.build-title span.build-id {
+    font-size: 1.5em;
+    font-weight: bold;
 }
 
-div.build-detail div.build-version span.build-commit {
-    color: #887;
-    font-style: italic;
+div.build-detail div.build-title span.build-id > span.build-state-normal {
 }
-
-div.build-detail div.build-state {
-    margin: .7em 0em 1em 0em;
-    font-size: 1.2em;
+div.build-detail div.build-title span.build-id > span.build-state-failed {
+    color: #a55;
+}
+div.build-detail div.build-title span.build-id > span.build-state-successful {
+    color: #5a5;
 }
 
-div.build-detail div.build-state > span.build-state-successful,
-div.build-detail div.build-state > span.build-state-failed {
-    padding: .3em .5em;
-    border-radius: .3em;
-    -moz-border-radius: .3em;
-    -ms-border-radius: .3em;
-    -webkit-border-radius: .3em;
-    color: white;
+div.build-detail div.build-title span.build-state-detail {
+    margin-left: .5em;
 }
 
-div.build-detail div.build-state > span.build-state-failed {
-    background: #a55;
+div.build-detail div.build-version {
+    line-height: 2em;
 }
-div.build-detail div.build-state > span.build-state-successful {
-    background: #5a5;
+
+div.build-detail div.build-version span.build-commit {
+    color: #887;
+    font-style: italic;
 }
 
 div.build-detail div.build-ideas {

diff --git a/readthedocs/templates/builds/build_detail.html b/readthedocs/templates/builds/build_detail.html
@@ -55,10 +55,50 @@
       {% endif %}
     </ul>
 
-    <div class="build-id">
-      {% blocktrans with build_id=build.pk %}
-        Build #{{ build_id }}
-      {% endblocktrans %}
+    <div class="build-title">
+
+      <span class="build-id">
+        <span class="build-state-normal"
+              data-bind="visible: !finished()">
+          {% blocktrans with build_id=build.pk %}
+            Build #{{ build_id }}
+          {% endblocktrans %}
+        </span>
+
+        <span class="build-state-successful"
+              data-bind="visible: finished() && success()"
+              style="display: none;">
+          {% blocktrans with build_id=build.pk %}
+            Build #{{ build_id }}
+          {% endblocktrans %}
+        </span>
+
+        <span class="build-state-failed"
+              data-bind="visible: finished() && !success()"
+              style="display: none;">
+          {% blocktrans with build_id=build.pk %}
+            Build #{{ build_id }}
+          {% endblocktrans %}
+        </span>
+      </span>
+
+      <span class="build-state-detail">
+        <span data-bind="visible: !finished(), text: state_display"
+              style="display: none;">
+          {{ build.get_state_display }}
+        </span>
+        <img src="{% static 'core/img/loader.gif' %}"
+            data-bind="visible: !finished()"
+            style="display: none;" />
+
+        <span data-bind="visible: finished() && success()"
+              style="display: none;">
+          <a class="" href="{{ build.version.get_absolute_url }}">
+            {% trans "view docs" %}
+          </a>
+        </span>
+      </span>
+
     </div>
 
     <div class="build-version">
@@ -75,28 +115,6 @@
       </span>
     </div>
 
-    <div class="build-state">
-      <span>
-        <span data-bind="visible: !finished(), text: state_display"
-              style="display: none;">
-          {{ build.get_state_display }}
-        </span>
-        <img src="{% static 'core/img/loader.gif' %}"
-            data-bind="visible: !finished()"
-            style="display: none;" />
-      </span>
-      <span class="build-state-successful"
-            data-bind="visible: finished() && success()"
-            style="display: none;">
-        {% trans "Build completed" %}
-      </span>
-      <span class="build-state-failed"
-            data-bind="visible: finished() && !success()"
-            style="display: none;">
-        {% trans "Build failed" %}
-      </span>
-    </div>
-
     {% if request.user|is_admin:project %}
       {% if not build.success and build.commands.count < 4 %}
         <div class="build-ideas">