Skip to content

Commit

Permalink
Remove calls to assign from django guardian
Browse files Browse the repository at this point in the history
This is related to readthedocs#5853
  • Loading branch information
stsewd committed Jun 27, 2019
1 parent 57da1f7 commit 6966752
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions readthedocs/builds/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
from django.utils.translation import ugettext
from django.utils.translation import ugettext_lazy as _
from django_extensions.db.models import TimeStampedModel
from guardian.shortcuts import assign
from jsonfield import JSONField
from polymorphic.models import PolymorphicModel
from taggit.managers import TaggableManager
Expand Down Expand Up @@ -246,8 +245,6 @@ def save(self, *args, **kwargs): # pylint: disable=arguments-differ
"""Add permissions to the Version for all owners on save."""
from readthedocs.projects import tasks
obj = super().save(*args, **kwargs)
for owner in self.project.users.all():
assign('view_version', owner, self)
broadcast(
type='app',
task=tasks.symlink_project,
Expand Down
3 changes: 0 additions & 3 deletions readthedocs/projects/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from django.template.loader import render_to_string
from django.utils.safestring import mark_safe
from django.utils.translation import ugettext_lazy as _
from guardian.shortcuts import assign
from textclassifier.validators import ClassifierValidator

from readthedocs.core.utils import slugify, trigger_build
Expand Down Expand Up @@ -484,8 +483,6 @@ def clean_user(self):

def save(self):
self.project.users.add(self.user)
# Force update of permissions
assign('view_project', self.user, self.project)
return self.user


Expand Down
3 changes: 0 additions & 3 deletions readthedocs/projects/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from django.utils.functional import cached_property
from django.utils.translation import ugettext_lazy as _
from django_extensions.db.models import TimeStampedModel
from guardian.shortcuts import assign
from six.moves import shlex_quote
from taggit.managers import TaggableManager

Expand Down Expand Up @@ -421,8 +420,6 @@ def save(self, *args, **kwargs): # pylint: disable=arguments-differ
if not self.slug:
raise Exception(_('Model must have slug'))
super().save(*args, **kwargs)
for owner in self.users.all():
assign('view_project', owner, self)
try:
latest = self.versions.filter(slug=LATEST).first()
default_branch = self.get_default_branch()
Expand Down

0 comments on commit 6966752

Please sign in to comment.