-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(in place): support in-place mutation #2706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `--inPlace` flag. When `inPlace` mode is active, mutations will be written in-place, overriding any local changes.
This was referenced Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--inPlace
flag (or equivalent in stryker.conf.json file). WheninPlace
istrue
(default isfalse
), mutations are written "in place", overriding the user's own files. This way, Stryker can support more exotic project configurations, where even copying to a temp directory breaks the test run. For example, when a project relies on app-root-path or uses theNODE_PATH
environment variable.Support for
--inPlace
added in theSandbox
class. For each file that changes, it writes a backup to a ".stryker-tmp/backup123" directory. After mutation testing completes, the backup files are recovered from the backup directory.Stryker tries its best to recover the backup files and when the process exits unexpectantly, for example, using
CTRL+C
or by closing the window. This behavior is a best-effort since Stryker can't do anything for you when you kill it from the task manager or withkill -9
.Fixes #2163
Todo:
unexpected-exit-handler.ts
stryker.ts
sandbox.ts
moveDirectoryRecursiveSync
inPlace
mode active..stryker-tmp
.constructor
anddispose