Skip to content

Conversation

@rouke-broersma
Copy link
Member

@rouke-broersma rouke-broersma commented May 7, 2023

fix #2493
fix #2495

image

@nicojs Is this how we want to deal with this breaking change? Since it's a forward breaking change accepting V1 and V2 schemas in the same schema should be fine right?

I don't understand how the e2e test for v2 schema I added didn't catch this in the dashboard...

@rouke-broersma
Copy link
Member Author

metrics scala does not seem to accept the Pending state even though it was added here:

I also see that the schemaVersion is still 1 in the mutationtestresult: https://github.com/stryker-mutator/mutation-testing-elements/blob/master/packages/metrics-scala/metrics/src/main/scala/mutationtesting/mutationTestResult.scala#L33

Should that be updated to 2 @hugo-vrijswijk?

@hugo-vrijswijk
Copy link
Member

metrics scala does not seem to accept the Pending state even though it was added here:

It looks like it wasn't fully added to the JSON codec here, I can't add it today, but feel free to add it: https://github.com/stryker-mutator/mutation-testing-elements/blob/master/packages/metrics-scala/circe/src/main/scala/mutationtesting/circe.scala#L110

I also see that the schemaVersion is still 1 in the mutationtestresult: https://github.com/stryker-mutator/mutation-testing-elements/blob/master/packages/metrics-scala/metrics/src/main/scala/mutationtesting/mutationTestResult.scala#L33

Should that be updated to 2 @hugo-vrijswijk?

Yes, though it's a default property so can be overridden if needed

@rouke-broersma
Copy link
Member Author

I have no clue why the integration tests are failing.. See: #2495

@rouke-broersma
Copy link
Member Author

rouke-broersma commented May 7, 2023

Avoid platform differences in whitespace in colour properties by trimming the actual value before comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

theme-changed CI browser tests failing on windows since some days Schema validation fails for schema version 2

3 participants