Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commands #35

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Remove commands #35

merged 2 commits into from
Aug 16, 2024

Conversation

Fazt01
Copy link
Contributor

@Fazt01 Fazt01 commented Aug 16, 2024

We don't want those complicated commands. ID gen is the only thing we want to be using. And I don't really want to move it elsewhere (and coming up with a name).

Also some minor fixes in second commit:

  • errors are logged (cobra does it by itself, when RunE returns an error)
  • version returns the version 👀 tested:
$ go run go.strv.io/tea/cmd/tea@8433586669367683e1e4e30612a6cf463eabf555 version
v0.4.1-0.20240816090731-843358666936

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (5323dc9) to head (8433586).

Files Patch % Lines
cmd/tea/version.go 0.00% 5 Missing ⚠️
cmd/tea/main.go 0.00% 4 Missing ⚠️
cmd/tea/gen_id.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #35       +/-   ##
===========================================
+ Coverage   29.75%   46.84%   +17.08%     
===========================================
  Files          10        5        -5     
  Lines         662      222      -440     
===========================================
- Hits          197      104       -93     
+ Misses        435       95      -340     
+ Partials       30       23        -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fazt01 Fazt01 merged commit f47a1fb into master Aug 16, 2024
2 of 3 checks passed
@Fazt01 Fazt01 deleted the remove_commands branch August 16, 2024 11:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants